Add a new optional rpId to Credential Record
#2258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I figured this seems fair at first, but as I read the PR I started thinking this might be a bit of a trap. See: #2257 (comment) |
|
I'd like to see this sentence augmented with a few words indicating why its useful to store the rpId as part of the credential record. Just something small to help folks understand the value of this. |
timcappalli
requested changes
Feb 22, 2025
| : <dfn>rpId</dfn> | ||
| :: The value of the <code>{{PublicKeyCredentialCreationOptions/rp}}.{{PublicKeyCredentialRpEntity/id}}</code> parameter | ||
| specified in the {{CredentialsContainer/create()}} operation during credential registration. | ||
| Storing this enables the [=[RP]=] to use the credential across different domains later |
There was a problem hiding this comment.
Suggested change
| Storing this enables the [=[RP]=] to use the credential across different domains later | |
| This is a core property of a credential and storing the value at creation time is recommended to assist with future operations such as audits, troubleshooting, or leveraging features such as [[#sctn-related-origins|Related Origin Requests]]. |
There was a problem hiding this comment.
some starter text. needs some work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2257
This PR adds
rpIdto Credential Record. This optional field is defined to try and help guide RPs, that wish to use Related Origins, to store values that will streamline adoption of the feature.Preview | Diff